raspberrypi / picotool

BSD 3-Clause "New" or "Revised" License
555 stars 95 forks source link

Support "reset" command for non BOOTSEL device with STDIO USB reset interface #13

Closed kilograham closed 1 year ago

kilograham commented 3 years ago

SDK 1.1.0 adds (optional) support for code exposing STDIO USB to be reset via another USB vendor interface. This obviously makes sense for the the "reset" command, though we should probably add a -f, --force or whatever option to make this happen.

lurch commented 3 years ago

IIRC that new USB vendor interface allows resetting to BOOTSEL or resetting to flash boot, so perhaps picotool should expose both those options?

kilograham commented 3 years ago

picotool already does

lurch commented 3 years ago

I guess that must be only in the Graham-version? https://github.com/raspberrypi/picotool/commits/master

kilograham commented 3 years ago

the picotool reboot already supports options to specify which type of boot you want (flash boot or usb boot), has since the get go; it is in master

lurch commented 3 years ago

Ahh, I was getting confused by the already-existing-reboot (i.e. over PICOBOOT?) and the new-USB-vendor-reboot. Also, I'd never thought to run picotool help reboot which is the only place where this is ever mentioned :stuck_out_tongue_winking_eye:

lurch commented 3 years ago

And based on our internal discussions, I wonder if picotool reboot also ought to have an option for "reboot into BOOTSEL mode but only enable PICOBOOT, don't enable the MSD interface" ? :shrug: