search

raspberrypi / picotool

BSD 3-Clause "New" or "Revised" License
579 stars 103 forks source link

Don't write more data than will fit in flash #73

Closed lurch closed 1 month ago

lurch commented 1 year ago

Updated version of #19

lurch commented 1 year ago

The previous version of this PR (#19) got (accidentally?) auto-closed again when the develop branch disappeared :confused:

I had a quick check, and AFAICT it looks like none of the other PRs got auto-closed because they're all based against the master branch rather than the develop branch? (but I didn't do a similar check for the pico-sdk or pico-examples repos, because there's lots of churn going on there and I've not been keeping up, so I wouldn't know which PRs are closed deliberately and which are closed accidentally)

EDIT: Ahhh, no need to panic as pico-sdk and pico-examples both have develop configured as a protected branch. TL;DR - should this repo also have develop as a protected branch? (and possibly on any other repo where we have a 3rd-party -> develop -> master "merge-policy")

kilograham commented 1 year ago

ah yes; i need to make develop not disappear!

lurch commented 1 year ago

@kilograham Bump, develop still isn't a protected branch :wink:

will-v-pi commented 1 month ago

Thanks, this has been merged for picotool 2.0.0 - and develop branch is now protected too