raspberrypi / piserver

Raspberry Pi Server wizard to serve Raspbian to network booting Pis
310 stars 60 forks source link

client login now provides a drop down list of userIds #39

Closed gbrickell closed 5 years ago

gbrickell commented 5 years ago

Hi - we have been very successfully using piserver for a School-based club for more than 12 months now and I routinely update the piserver machine as well as the 'served' Raspbian version. In the last few weeks however the client login screen has started to provide a drop down list of all the currently available userIds instead of the user having to type in their individual userId.

I don't think this is something I have somehow inadvertently done but revealing all the userIds seems somewhat insecure so could this be simply modified by a config somewhere or would it need a code update?

Thanks

Geoff

spl237 commented 5 years ago

When you say "in the last few weeks", can you be any more specific? We pushed an updated build of Raspbian last Friday (16th Nov) and made some additional changes over the weekend - did the problem occur before or after that? Many thanks.

gbrickell commented 5 years ago

Hi - to be honest I'm not absolutely sure but I think it was there before the 16th Nov - but just to say that I did do another set of full updates just before posting this Issue and the problem is still there

spl237 commented 5 years ago

OK, thanks for checking.

maxnet commented 5 years ago

As a temporary workaround, press "shell" button in piserver, run "leafpad /etc/lightdm/lightdm.conf", and change the "greeter-hide-users=false" option to "greeter-hide-users=true"

gbrickell commented 5 years ago

Thanks - that has sorted things for now and I can obviously check that .conf whenever I do an update/upgrade going forward but hopefully - as you say its a "temporary workaround" - you will be able to do something in the main distro code at some point.

I'll will now close this item - and thanks for the very prompt fix.

spl237 commented 5 years ago

Just FYI - I've found the original problem in one of our packages; we're pushing a fix to our repo in the next day or so, so future updates should be fine. Apologies for the inconvenience.

gbrickell commented 5 years ago

OK - thanks for letting me know