search

raspberrypi / rpi-eeprom

Installation scripts and binaries for the Raspberry Pi 4 and Raspberry Pi 5 bootloader EEPROMs
https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#raspberry-pi-boot-eeprom
Other
1.26k stars 201 forks source link

rpi-eeprom-config - Fix handling of bootcode arg #566

Closed timg236 closed 5 months ago

timg236 commented 5 months ago

Update to allow all file replacement arguments to be passed in a single call.

Also, add debug flags and update the instructions for installing pycryptodome

timg236 commented 5 months ago

@tdewey-rpi - Please could check if this resolves the problem that you were seeing?

lurch commented 5 months ago

Looking at the code, it seems like some options are ignored if other options aren't set? Perhaps it's worth checking for these invalid combinations (e.g. specifying --digest without also specifying --config) and printing out a suitable error-message, in order to prevent user-confusion? :shrug:

timg236 commented 5 months ago

All the signing stuff is wrapped so I think it's ok