search

raspberrypi / rpi-imager

The home of Raspberry Pi Imager, a user-friendly tool for creating bootable media for Raspberry Pi devices.
https://www.raspberrypi.com/software
Other
1.66k stars 253 forks source link

[BUG] New Icon Doesn't Match Apple Design Guidelines #746

Open Logicer16 opened 10 months ago

Logicer16 commented 10 months ago

Describe the bug Following up on #695, the new icon is too large and has a smaller corner radius than what Apple's Human Interface Guidelines. This is contrary to the goal stated in https://github.com/raspberrypi/rpi-imager/issues/695#issuecomment-1773740128:

the desire was [an] icon ... that also complied with the Apple HI guidance.

To Reproduce Include steps to allow us to reproduce the error. Include your host OS, and the version of Raspberry Pi Imager.

  1. View the imager's icon next to icons of other Mac apps.

Expected behaviour The new icon to meet the goal of conforming to the Apple Human Interface Guidelines.

Screenshots or video Comparing it with other icons in the dock makes the discrepancy quite striking

Screen Shot 2023-11-30 at 5 56 44 pm

Placing the icon against Apple's provided template shows exactly by how much the new icon is off.

Screen Shot 2023-11-30 at 6 09 43 pm

The micro SD card is fine as is though as it is a tool external from the main icon, which is permitted by the guidelines.

Desktop (please complete the following information):

The name of the OS you are trying to write N/A

Are you using OS Customisation? N/A

Additional context N/A

tdewey-rpi commented 10 months ago

Thanks for the report, @Logicer16.

@jackbenwillis Have I mangled your asset in the merge?

tdewey-rpi commented 10 months ago

Also, thank you @Logicer16 for taking the time to assemble a visual aide. This is greatly appreciated when reporting UI concerns in particular.

tdewey-rpi commented 10 months ago

Thanks for the catch, @Logicer16. We'll look to revise the asset, but this is unlikely to happen in 2023.

elsiehupp commented 7 months ago

I mentioned this on #397:

I have made Big-Sur-style icons for other projects, and most recently I merged this template over at the Nextcloud Desktop repository:

Nextcloud-macOS-icon.svg

Nextcloud-macOS-icon.svg

This is a 100% vector Big-Sur-style icon, layer effects and all, and the above link should go to the code view, not the image preview.

(The annotation formatting apparently broke the build process in way that wasn't caught by the continuous integration, though...)

Anyway as you can see in the code annotation, I (as the author of the SVG document) released the template under a CC0 Public Domain Dedication, so hopefully this can be some help in creating a Big-Sur-style version of the RPI Imager icon!

(I should also note that the template is versatile enough that it should be useful for icon shapes other than the Apple "Squircle"—the annotations explain which SVG element to replace for a different shape.)

If you'd like to use this as template, it should be substantially closer to the Apple guidelines.