raspberrypi / rpi-imager

The home of Raspberry Pi Imager, a user-friendly tool for creating bootable media for Raspberry Pi devices.
https://www.raspberrypi.com/software
Other
1.55k stars 233 forks source link

[BUG]: Imager installation configuration #868

Open WhoIsAvailable opened 1 month ago

WhoIsAvailable commented 1 month ago

What happened?

A bug happened! When the user chooses to set the installation configuration options, the Imager should check to see whether SSH is actually available on the host machine before allowing the selection of the generation of a new private key. If SSH is not available then the Imager should not allow the selection of that option.

It should also explain what information is required to be entered on the line underneath the “Allow” button.

The “Getting started - Raspberry Pi Documentation” also needs to provide more information about the use of this option.

I was running on Win7Pro SP1 where it seems that I have no native version of SSH.

Version

1.8.5 (Default)

What host operating system were you using?

Windows

Host OS Version

Win7Pro SP1

Selected OS

Bookworm 64 bit

Which Raspberry Pi Device are you using?

Raspberry Pi 5

What kind of storage device are you using?

USB Pen Drive

OS Customisation

Relevant log output

None whatsoever
lurch commented 1 month ago

I was running on Win7Pro SP1

I strongly suspect that we won't be making tweaks to Imager to support an OS that's been officially unsupported for over 4 years.

The “Getting started - Raspberry Pi Documentation” also needs to provide more information about the use of this option.

If you have documentation suggestions, please create a separate issue at https://github.com/raspberrypi/documentation

WhoIsAvailable commented 1 month ago

As reported, the bug has nothing to do with the fact that I am still running Win7. I could agree with your decision if you provided evidence that the Imager does check for the existence of SSH or some similar product when running under other operating systems.


From: Andrew Scheller @.> Sent: 12 May 2024 17:41 To: raspberrypi/rpi-imager @.> Cc: WhoIsAvailable @.>; Author @.> Subject: Re: [raspberrypi/rpi-imager] [BUG]: Imager installation configuration (Issue #868)

I was running on Win7Pro SP1

I strongly suspect that we won't be making tweaks to Imager to support an OS that's been officially unsupportedhttps://en.wikipedia.org/wiki/Windows_7#End_of_support_(after_January_14,_2020) for over 4 years.

The “Getting started - Raspberry Pi Documentation” also needs to provide more information about the use of this option.

If you have documentation suggestions, please create a separate issue at https://github.com/raspberrypi/documentation

— Reply to this email directly, view it on GitHubhttps://github.com/raspberrypi/rpi-imager/issues/868#issuecomment-2106310426, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BINCCCP3ISXQ5YAHGF3GAVDZB6LVBAVCNFSM6AAAAABHRAB26OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGMYTANBSGY. You are receiving this because you authored the thread.Message ID: @.***>

maxnet commented 1 month ago

It does check for the existence, and grays out the "ssh key-gen" button for you. It still allows you to check the "use public authentication" box so that you can manually copy and paste a public key, you generated though other means though.

Why do you believe that is a problem?

WhoIsAvailable commented 1 month ago

In that case, I can understand why you do not feel that it would be worthwhile making a change just for Win7. Thanks for the clarification.


From: maxnet @.> Sent: 25 May 2024 10:28 To: raspberrypi/rpi-imager @.> Cc: WhoIsAvailable @.>; Author @.> Subject: Re: [raspberrypi/rpi-imager] [BUG]: Imager installation configuration (Issue #868)

It does check for the existence, and grays out the "ssh key-gen" button for you. It still allows you to check the "use public authentication" box so that you can manually copy and paste a public key, you generated though other means though.

Why do you believe that is a problem?

— Reply to this email directly, view it on GitHubhttps://github.com/raspberrypi/rpi-imager/issues/868#issuecomment-2131160727, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BINCCCOWNUQLUPJGZWHALQ3ZEBKTLAVCNFSM6AAAAABHRAB26OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGE3DANZSG4. You are receiving this because you authored the thread.Message ID: @.***>