search

raspberrypi / rpi-imager

The home of Raspberry Pi Imager, a user-friendly tool for creating bootable media for Raspberry Pi devices.
https://www.raspberrypi.com/software
Other
1.71k stars 262 forks source link

[FEATURE]: Add Advanced Options to Menu Bar #955

Open warpling opened 2 weeks ago

warpling commented 2 weeks ago

Is your feature request related to a problem? Please describe.

When I first flashed my SD card from a custom image I was asked what advanced options I wanted to configure. When I later flashed a more standard image I wasn't so I thought it wasn't possible to configure things like SSID. I needed this for my headless setup but because there was no button or even menu bar item for Advanced Options I assumed they were unavailable.

Describe the solution you would like to see implemented

There should be a button for accessing advanced options OR if there is a desire to keep most people away from them, only place it in the menu. A more advanced UX idea would be to permanently show the "Advanced Options" in the UI if the user has ever used them.

Describe alternatives you've considered

As smaller pis become popular so will headless configuration thus it should become easier not harder to set this up :)

Additional context

I was going to attach the app version of the mac app doesn't appear to have an About item in the menu bar either! These little things would go a long way to making the new user experience in 2024 better :)

Version

1.9.2 (Default)

lurch commented 2 weeks ago

See also the related comments on #941 and #213

warpling commented 2 weeks ago

@lurch oh woah, does this mean customization is ignored for "non-custom" images?

lurch commented 2 weeks ago

Nah, it means that the OS's metadata in https://downloads.raspberrypi.com/os_list_imagingutility_v4.json explicitly needs to specify what kind of customisation the image wants.

warpling commented 2 weeks ago

and if the metadata doesn't then the settings config screen won't display but the set settings themselves are still applied?

lurch commented 2 weeks ago

If the metadata doesn't specify any customisation, then this dialogue won't appear: Screenshot from 2024-10-30 14-37-46 and no settings will be applied to the image.

warpling commented 2 weeks ago

Ahhh okay, even if I bring up the customize screen with the keyboard shortcut and load a custom image?

lurch commented 2 weeks ago

I'm gonna defer to @tdewey-rpi here for the definitive answer, because I don't want to guess and get it wrong...

tdewey-rpi commented 2 weeks ago

If you use the debug shortcut to open the OS customisation window against an OS that does not typically offer customisation, this is an unsupported action.

The customisation script will be written - but may have some, no, or a completely adverse effect.

I will be constraining the keyboard shortcut to remove that option on official builds, because it simply cannot offer a consistently good experience.

On 30 Oct 2024, at 15:41, Andrew Scheller @.***> wrote:

I'm gonna defer to @tdewey-rpi https://github.com/tdewey-rpi here for the definitive answer, because I don't want to guess and get it wrong...

— Reply to this email directly, view it on GitHub https://github.com/raspberrypi/rpi-imager/issues/955#issuecomment-2447585508, or unsubscribe https://github.com/notifications/unsubscribe-auth/BC7TZM4C3OH2XY67PHDUKMDZ6D4Z7AVCNFSM6AAAAABQ33LJISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGU4DKNJQHA. You are receiving this because you were mentioned.

warpling commented 2 weeks ago

Hey @tdewey-rpi, that's good to know that but as someone brand new to pis and still learning how they work I assumed all OSes respected these conf settings at a very low level; it may be safe to assume others cobbling tutorials together, trying to get their pi to connect to wifi out of the box may then too.

I would guess that adding this option to the menu bar and greying it out when official builds are selected would communicate what's going on to users much more clearly than simply disabling the hotkey and making people wonder why sometimes the settings pop-up and sometimes they don't during certain installs. What do you think?

tdewey-rpi commented 1 week ago

Hey @tdewey-rpi, that's good to know that but as someone brand new to pis and still learning how they work I assumed all OSes respected these conf settings at a very low level; it may be safe to assume others cobbling tutorials together, trying to get their pi to connect to wifi out of the box may then too.

I would guess that adding this option to the menu bar and greying it out when official builds are selected would communicate what's going on to users much more clearly than simply disabling the hotkey and making people wonder why sometimes the settings pop-up and sometimes they don't during certain installs. What do you think?

Thanks for the suggestion, @warpling

Your assumption is exactly what I want to avoid violating - and is a completely fair one to have made. I can only apologise that rpi-imager has fallen short in this respect.

There's another issue in this repository where I've outlined my plan for communicating what's going on - but essentially I want to add another button to the UI that will be grey/enabled as you select an OS that supports customisation, and include this in the work to make customisation more robust.

I wouldn't expect to see a release where you didn't get the entire feature - so the hotkey would not be disabled without having a replacement mechanism.

warpling commented 1 week ago

That sounds like a great plan!

Thanks for making getting into this world easier and for the quick replies!