search

raspberrypi / tinyusb

MIT License
69 stars 18 forks source link

usbd ack SET_INTERFACE if it is not implemented by class driver. #10

Closed xAsKaNx closed 2 years ago

xAsKaNx commented 3 years ago

Describe the PR This pull request solves a problem with WebUSB on Linux and probably also Mac OS. Without this patch trying to use WebUSB ends in error messages "NetworkError: Unable to set device interface."

This patch is not from me (correct author has been added) and originates from: https://github.com/hathach/tinyusb/pull/711

I've tested the patch and with it applied, I can use the RPi Pico with WebUSB on Linux.

lurch commented 3 years ago

Is this fix already included in tinyusb 0.9.0 ? See https://github.com/raspberrypi/pico-sdk/pull/321

xAsKaNx commented 3 years ago

It is. So it depends on when you want to merge the new version. If it takes longer it may be helpful if you merge this smaller change in the mean time.

lurch commented 3 years ago

That's entirely a @kilograham decision.

kilograham commented 3 years ago

i mean i could merge it, but the sdk tinyusb submodule ref isn't going to get bumped until the next release which will pick up 0.9.0 anyway. It should be in under 2 weeks

lurch commented 3 years ago

I guess this can be closed, now that 0.10.1 has been merged in?