search

raspberrypi / usbboot

Raspberry Pi USB booting code, moved from tools repository
Apache License 2.0
878 stars 221 forks source link

Add tag on release #155

Closed bcecchinato closed 1 year ago

bcecchinato commented 1 year ago

Hello !

Is it possible to tag all releases ? This would allow to clone the tag with depth=1 and not the entire history :)

Thanks in advance.

pelwell commented 1 year ago

What do you mean by "releases"? A tag is just a label on a commit - commit hashes can be used in just the same way if you know what you want.

bcecchinato commented 1 year ago

Not exactly, a tag is also a ref in git, which means you can clone like this git clone --depth=1 your_tag https://github.com/raspberrypi/usbboot. This will reduce the clone to 1 commit and makes it very fast.

It is not possible to clone based on a sha1 without cloning the whole tree (and thus makes the clone way more longer), except if there is ref attached to the sha1 (like a tag or a branch).

By release I mean every commit name "release XXXX" for instance 20220815~145439 release.

timg236 commented 1 year ago

Realistically no, I'm not going to remember to do this

pelwell commented 1 year ago

Interesting - I'd not come across the "only named branches/tags" limitation of git clone before. It's apparently a security feature, to protect against old (potentially dangerous or embarassing) commits from being downloaded after they've been removed from a repo but not yet pruned.

bcecchinato commented 1 year ago

Yep :) I know that other repos like https://github.com/raspberrypi/linux and https://github.com/raspberrypi/firmware are using tags which is very pratical to avoid this problem.

Anyway, that's your call. I know it can be done in 1 click on github (or one push with git tag XXX + git push origin XXX Too bad this is not possible to "suggest" as a PR or something :(

jcgruenhage commented 1 year ago

I'd like to weigh in on this: This is not necessarily about remembering. If you forget to tag it in git, fine, so be it, we'll remember for you and remind you when it happens. For users and distributions alike, it'd be very nice to have tags available, so that packaging this software becomes feasible. Having to keep those tags of which version number refers to which commit hash in each distribution is clearly more work compared to keeping it in one place, upstream.

UffeJakobsen commented 1 year ago

I agree !!!