search

raspberrypi / usbboot

Raspberry Pi USB booting code, moved from tools repository
Apache License 2.0
913 stars 231 forks source link

Update install_script.nsi #193

Closed mennovf closed 9 months ago

mennovf commented 9 months ago

In commit 467bee5f32bbbe6df2a450eab8fd1230860dfbbb the registry key got changed from "Software\Compute Module Boot" to "Software\Raspberry Pi". In the same commit the .onInit function was added to check whether rpiboot was already installed, but referenced the old key in the registry. The result is that this "already installed" check effectively doesn't happen.

andrum993 commented 9 months ago

Would it not be preferable to test both registry keys? If you change it to only test the new key, then it will not detect when there is an older version already installed, i.e. one where the old key was used.

mennovf commented 9 months ago

I'll happily add the second check if that's what the maintainers want. There is a second issue though: the registry key is not removed on uninstall. I'm not well versed enough in NSIS scripts to know when would be the correct point in the installation procedure to do this.

timg236 commented 9 months ago

Seems like a good idea.