search

raspberrypi / usbboot

Raspberry Pi USB booting code, moved from tools repository
Apache License 2.0
905 stars 229 forks source link

Added Docker build chain #31

Closed GeorgeSapkin closed 2 years ago

GeorgeSapkin commented 6 years ago

This simplifies building on any machine that has Docker without installing any build dependencies.

mi-hol commented 2 years ago

it seems this change was actually implemented (maybe without merging) hence could be closed. Or did I miss to see an important diff?

timg236 commented 2 years ago

I don't think this is something that Raspberry Pi would use or maintain

mi-hol commented 2 years ago

this change was actually implemented

Oops I was looking at the wrong file. @timg236 , I can understand your reply but was original poster made aware? Just leaving a PR unanswered & unactioned isn't a good practice :(

pelwell commented 2 years ago

PRs which aren't obviously wanted are often let to sit around for a while in case one of decides it is worth having after all, or perhaps the OP makes changes or just prods, but closing also works.

mi-hol commented 2 years ago

"house keeping" activities help to keep a "house" clean, from my view the same concepts (like "spring cleaning" ) help a repository to stay in order.