search

raspberrypi / usbboot

Raspberry Pi USB booting code, moved from tools repository
Apache License 2.0
905 stars 229 forks source link

requiring sudo is just plain wrong #44

Closed laf0rge closed 3 years ago

laf0rge commented 5 years ago

A program that at runtime checks if it's running as root, rather than checking for the actual permissions that it requires. I don't think I've seen such bad practise any time before, to be honest.

I don't really see why the program would require to run as root. Root privileges are way too powerful. All that's needed appears to be access to some USB devices. So the proper solution is to ship udev rules for those vid/pid combinations, rather than forcing people to run code with way too high privileges.

ghollingworth commented 5 years ago

Sure, would be happy to look at the pull request

QuLogic commented 4 years ago

Isn't that #27?

lurch commented 3 years ago

I guess this can be closed, now that #27 has been merged?