search

raspberrypi / usbboot

Raspberry Pi USB booting code, moved from tools repository
Apache License 2.0
905 stars 229 forks source link

Do not embed MSD firmware into rpiboot binary #61

Closed oskar456 closed 2 years ago

oskar456 commented 4 years ago

Although the binary has been altered to support reading firmware files from arbitrary directory and default MSD firmware is always installed into /usr/share/rpiboot/msd, there is still a copy of MSD firmware linked directly into the rpiboot binary, bloating it for more than 500 kB without a strong reason.

This commit makes this optional and alters Makefile in a way it is built without the embedded firmware by default.

Signed-off-by: Ondřej Caletka ondrej@caletka.cz

timg236 commented 3 years ago

This PR appears to change the default behaviour to exclude the MSD_FIRMWARE which is presumably why it hasn't been merged.

It the PR was changed to so that excluding the MSD_FIRMWARE was an option then I think it would be accepted. e.g. make EMBED_FIRMWARE=0