search

raspberrypi / userland

Source code for ARM side libraries for interfacing to Raspberry Pi GPU.
BSD 3-Clause "New" or "Revised" License
2.05k stars 1.09k forks source link

Replace 'arch' with uname #591

Closed solskogen closed 5 years ago

JamesH65 commented 5 years ago

Since man arch says "arch - print machine hardware name (same as uname -m)" this LGTM.

popcornmix commented 5 years ago

@solskogen can you explain why? Are you running this on a distribution that doesn't support arch?

solskogen commented 5 years ago

Not every distribution comes with "arch", which is used in buildme.

popcornmix commented 5 years ago

Which distribution are you using that doesn't have arch?

solskogen commented 5 years ago

Arch Linux ARM and Manjaro (which is based on Arch) doesn't come with 'arch', but when replaced with $(uname -m) it works perfectly.

pelwell commented 5 years ago

See https://github.com/raspberrypi/userland/issues/590 for context.

pelwell commented 5 years ago

LGTM.