search

raspberrypi / userland

Source code for ARM side libraries for interfacing to Raspberry Pi GPU.
BSD 3-Clause "New" or "Revised" License
2.05k stars 1.09k forks source link

vcsm: properly handle too many CMA allocation attempts #691

Closed doe300 closed 3 years ago

doe300 commented 3 years ago

Now will properly report errors instead of crashing due to writing to NULL pointer, fixes #690.

6by9 commented 3 years ago

Yup, looks good to me. I'll wait in case anyone else has any input before merging.

pelwell commented 3 years ago

My only objection is a stylistic one. I can see that there are multiple styles of whitespace use within this file, but at the very least any changes should be self-consistent. My preference is to not put additional whitespace inside the function calls, i.e. your munmap(...) call is good and your vcsm_free( ... ) call is bad,

pelwell commented 3 years ago

I'm happy with that.