search

raspberrypi / utils

A collection of scripts and simple applications
BSD 3-Clause "New" or "Revised" License
136 stars 41 forks source link

Added EEPROM #4

Closed ghost closed 4 years ago

pelwell commented 4 years ago

That looks good as far as it goes. My only remaining concern is about the behaviour on other devices - I think it would be better to skip that section altogether for Pis other than the 4B.

ghost commented 4 years ago

On all but the Pi 4B, rpi-eeprom-update runs and does nothing, so it's safe. (The first thing it does is check it's running on a Pi 4B and exits if it isn't).

pelwell commented 4 years ago

An empty Pi 4 section on a Pi 3 seems a bit ugly. What do you think, @JamesH65 ?

JamesH65 commented 4 years ago

@RaspberryPiFan Any reason why the script cannot check if its on a Pi4 and only add that section if it is?

ghost commented 4 years ago

@JamesH65 @pelwell I added a check.

pelwell commented 4 years ago

Thanks - I'm happy with that.