search

raspberrypi / windows-drivers

Windows IOT drivers
MIT License
120 stars 33 forks source link

bcmemmc2: Change NTarm64 to NT$ARCH$ #10

Closed christopherco closed 3 years ago

christopherco commented 3 years ago

CI indicates that InfVerif is throwing build errors.

d:\a\windows-drivers\windows-drivers\drivers\sd\bcm2711\bcmemmc2\bcmemmc2.inx : error 1203: Section [broadcom.ntarm] not found. [D:\a\windows-drivers\windows-drivers\drivers\sd\bcm2711\bcmemmc2\bcmemmc2.vcxproj]

Change the section naming to NT$ARCH$

Signed-off-by: Christopher Co 35273088+christopherco@users.noreply.github.com

christopherco commented 3 years ago

Looking a bit closer, this is probably not the full fix. On the ARM64 CI builds, looks like bcmemmc2 is actually building for ARM - https://github.com/christopherco/windows-drivers/pull/3/checks?check_run_id=2154886827

Not sure if bcmemmc2 is meant to build for both ARM and ARM64, but at least this change makes CI happy.

mariobalanica commented 3 years ago

There's a mistake in the solution file that makes bcmemmc2 build for ARM when the configuration is in fact set to ARM64 Debug. I'll push the fix after merging this.

mariobalanica commented 3 years ago

https://github.com/raspberrypi/windows-drivers/commit/7e437d47fa6e68247aa9722411dea9d40d7ce49d