raspiblitz / raspiblitz-web

A mobile-first responsive Web UI for the RaspiBlitz
MIT License
61 stars 21 forks source link

Setup-Redesign: Needs Finetune On Recovery #747

Closed rootzoll closed 1 month ago

rootzoll commented 1 month ago

I did on the v1.11.1rc1 a recovery (not a fresh setup) and on final screen ran into this:

Bildschirmfoto 2024-07-10 um 20 57 22

And then after restart it changed after a spinner to this screen:

Bildschirmfoto 2024-07-10 um 21 00 33

Its not an initial synchronization - its just starting up. And if the state is not clear .. is lightning, unlocked (its not it just jumped later to need unlock), still starting or has problems?

The new screen look really good, but for final release we would need some refinement on the status of the node here I think. Let me know what you need from the RaspiBlitz system side - I made a reminder ticket here: https://github.com/raspiblitz/raspiblitz/issues/4644

escapedcat commented 1 month ago

Do you know what data you get from these calls for each screen?

Would be great to be able to mock this to fix these issues. Started to try to fix things blind in #748

rootzoll commented 1 month ago

I dont habe the data. Do you mean like recording network calls with Browser-DevTools open or calling the API by hand?

This BTW is the srceen on a normal setup under firefox: Bildschirmfoto 2024-07-18 um 15 29 45

rootzoll commented 1 month ago

Just another observation: When I clicked "OK do restart" in the screen above. It jumped to the url http://192.168.178.60/login?back=/setup and showing the following screen:

Bildschirmfoto 2024-07-18 um 15 44 27

No restart was triggered. I entered Password A and it showed me the new design screen with the passwords again. When I then clicked "OK do restart" it started to trigger the final reboot.

Maybe it was because I was letting the node setup for a long time and my session already outdated - I get it but to new users this seems more like a bug. Can we have sessions that have a much longer time before outdating or an auto-refresh of the session done by the webui on that screen?

escapedcat commented 1 month ago

I'll take care of the layout issues and will try to compare the current state to the previous "pre redesign" state as soon as I find some time.

escapedcat commented 1 month ago

This BTW is the srceen on a normal setup under firefox: Bildschirmfoto 2024-07-18 um 15 29 45

Which Firefox is this? Version/OS/...? Can't reproduce this

escapedcat commented 1 month ago

And then after restart it changed after a spinner to this screen:

Bildschirmfoto 2024-07-10 um 21 00 33

Its not an initial synchronization - its just starting up. And if the state is not clear .. is lightning, unlocked (its not it just jumped later to need unlock), still starting or has problems?

According to the code this headline wasn't changed. The lightning-wallet functionality was there as well, only the design was updated. Do we know if this screen was shown after a recovery-restart before the design-relaunch as well or if something else was shown?

rootzoll commented 1 month ago

Which Firefox is this? Version/OS/...? Can't reproduce this

FIrefox 128.0 MacOS

Do we know if this screen was shown after a recovery-restart before the design-relaunch as well or if something else was shown?

I think it was also before like this - its not critical .. we can move this part to v1.11.2 - I opend ticket on raspiblitz repo #4652

escapedcat commented 1 month ago

Which Firefox is this? Version/OS/...? Can't reproduce this FIrefox 128.0 MacOS

Pushed a fix. Screen was optimized for Rick Astley words :P

Do we know if this screen was shown after a recovery-restart before the design-relaunch as well or if something else was shown? I think it was also before like this - its not critical .. we can move this part to v1.11.2 - I opend ticket on raspiblitz repo #4652

Alright, then I do not investigate further, ok?

rootzoll commented 1 month ago

@escapedcat on a recovery final setup screen there is still the checkbox "If i have written down my seed words" (what is not needed on recovery) Bildschirmfoto 2024-07-24 um 13 55 08

rootzoll commented 1 month ago

@escapedcat Oh and I was not able to click "OK, do final Reboot" button (its deactivated) and it even stays deactivated when I do the checkbox. So that is critical: I am stuck at this page.

escapedcat commented 1 month ago

Alright, will check

rootzoll commented 1 month ago

Also similar when setting up a fresh node ... the Button to continue on the final screen (here with a node Bitcoin only - no seed words) stays deactovated independent of the checkbox state. Is this already addressed in the PR #752 ? Bildschirmfoto 2024-07-24 um 15 29 19

escapedcat commented 1 month ago

Also similar when setting up a fresh node ... the Button to continue on the final screen (here with a node Bitcoin only - no seed words) stays deactovated independent of the checkbox state. Is this already addressed in the PR #752 ? !

Should be, yes 🤞

rootzoll commented 1 month ago

Should be, yes 🤞

Looks good on first tests

rootzoll commented 1 month ago

OK were good now thx - building an RC3.