rastabrane / websmsdroid

Automatically exported from code.google.com/p/websmsdroid
1 stars 0 forks source link

Outbound msg delivery fails/hangs and/or crashes o2 connector #730

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Send msg via o2 connector

Expect: delivered msg
Actual: a) notification: "Fehler beim Senden der SMS"
        OR b) symbol indicating the msg is being sent atm. lingers forever in notification area.
        OR c) o2 connector crashes ( promted to send crashreport )

WebSMS 4.4.2; o2 connector: 1.7.4
Phone: GT-I9000 4.0.4 IMM76L

Please provide any additional information below.
Is it possible the app waits for an ad to display and times out because I use 
AdFree ( redirects known ad servers to localhost ).
The error is not reliably reproducible, sometimes it works, sometimes not.

Kind regards, 
Ingo

Original issue reported on code.google.com by ingo.kro...@gmail.com on 3 Jul 2012 at 12:31

GoogleCodeExporter commented 9 years ago
Issue 731 has been merged into this issue.

Original comment by f...@ub0r.de on 3 Jul 2012 at 4:28

GoogleCodeExporter commented 9 years ago
Please check, if it is the connector crashing or websms.
please provide logs from that crash from within websms after getting this crash.

Original comment by f...@ub0r.de on 3 Jul 2012 at 4:30

GoogleCodeExporter commented 9 years ago
Hi, 

It is the connector that is crashing. The log contains a bit of a stacktrace.
From the log it seems to me that indeed the thread which displays the ads 
causes the hickups.
@see L124ff

Kind regards,
Ingo

Original comment by ingo.kro...@gmail.com on 5 Jul 2012 at 1:32

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the log. It seems to be a duplicate of another bug, some new ICS
limitation. I will check as soon as I can get to a PC.
Am 05.07.2012 15:32 schrieb <websmsdroid@googlecode.com>:

Original comment by sca...@gmail.com on 5 Jul 2012 at 4:33

GoogleCodeExporter commented 9 years ago
right. you never should have used network IO on the main thread.
with ICS the app will fail when doing so. ;)

Original comment by f...@ub0r.de on 5 Jul 2012 at 6:16

GoogleCodeExporter commented 9 years ago
It's in the legacy code ;) Which version of android are you running
specifically?
Am 05.07.2012 20:16 schrieb <websmsdroid@googlecode.com>:

Original comment by sca...@gmail.com on 6 Jul 2012 at 10:56

GoogleCodeExporter commented 9 years ago
Hi, 
It's one of cyanogenmod current nightly builds for the Galaxy S based on ICS.
http://download.cyanogenmod.com/?type=nightly&device=galaxysmtd

4.0.4 IMM76L

Original comment by ingo.kro...@gmail.com on 9 Jul 2012 at 7:33

GoogleCodeExporter commented 9 years ago
I can not reproduce this bug on a stock JellyBean emulator image. Receiving 
balance and sending an SMS works fine. Felix, any ideas?

Original comment by sca...@gmail.com on 27 Jul 2012 at 11:36

GoogleCodeExporter commented 9 years ago

Original comment by sca...@gmail.com on 27 Jul 2012 at 11:36

GoogleCodeExporter commented 9 years ago
need more infos?
here:

Generated with SendLog 1.1.2

Galaxy Nexus maguro 4.1.1 JRO03C

http://L6n.org/android/

Attachment: SendLog.txt (11 kb)

Original comment by oliver.s...@googlemail.com on 27 Jul 2012 at 11:56

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, unfortunately there is no relevant output in that log. Please try 
installing the attached APK and collect a full log.

Again, thanks!

Original comment by sca...@gmail.com on 27 Jul 2012 at 12:42

Attachments:

GoogleCodeExporter commented 9 years ago
Hi, 

I used the debug build. Here's the log.

Kind regards,
Ingo

Original comment by ingo.kro...@gmail.com on 27 Jul 2012 at 1:04

Attachments:

GoogleCodeExporter commented 9 years ago
That debug build writes login and password for the o2 account and also the 
personal email adress in clear text into the system log. I suggest you change 
that immediately and mask those outputs. 
That kind of program behaviour is highly irresponsible and could be seen as 
malicious intent.

Ingo

Original comment by ingo.kro...@gmail.com on 27 Jul 2012 at 1:43

GoogleCodeExporter commented 9 years ago
Issue 722 has been merged into this issue.

Original comment by f...@ub0r.de on 27 Jul 2012 at 2:11

GoogleCodeExporter commented 9 years ago
@scahoo: i think there is a switch for the emulator making it behave like a 
standard device. running (network) IO on UI/main thread was never best 
practice. with ICS it will kill the app to make developers stick to best 
practice.
i really would like to help here, but your code obfuscation prevents it. :(

@ingo+scahoo: when building the app with ub0rlibs deploy-release.sh all Log.d() 
calls will get removed in production release.

Original comment by f...@ub0r.de on 27 Jul 2012 at 2:15

GoogleCodeExporter commented 9 years ago
Sorry about that. I previously opened a bugreport on that, as its a
behaviour from the websms API. I still believe that the correct way forward
is to make post data logging optional, and not the default. Felix, what for
you think?

Ingo: can you remove / repost the offending log file? Anything else I can
do? This should not have happened, especially since you're helping me to
fix this bug.

Original comment by sca...@gmail.com on 27 Jul 2012 at 2:26

GoogleCodeExporter commented 9 years ago
@scahoo 
No harm done, my attached log does not contain such sensitive data. But I 
intended to post another log with the "SendLog" app and found it to contain my 
personal data.

Kind regards,
Ingo

Original comment by ingo.kro...@gmail.com on 27 Jul 2012 at 2:30

GoogleCodeExporter commented 9 years ago
i just hacked a few lines to hide this data by default.
@scahoo: please pull my master.

https://github.com/felixb/websms-api/commit/725310e06f51b6108019c9ea87a4cd39ad5d
d871

Original comment by f...@ub0r.de on 27 Jul 2012 at 7:03

GoogleCodeExporter commented 9 years ago
Felix: Thanks for the quick fix. I get an PatternSyntaxExpression error if
I disable verbose logging though. Please see:
https://github.com/felixb/websms-api/commit/725310e06f51b6108019c9ea87a4cd39ad5d
d871#src-de-ub0r-android-websms-connector-common-utils-java-P35

Original comment by sca...@gmail.com on 28 Jul 2012 at 12:33

GoogleCodeExporter commented 9 years ago
Ingo: Do you have "Ignore invalid SSL..." enabled?

2012/7/28 Lorenz Bauer <scahoo@gmail.com>

Original comment by sca...@gmail.com on 28 Jul 2012 at 12:36

GoogleCodeExporter commented 9 years ago
I found the error, and will push the changes as soon as Felix has updated the 
API. Please try the attached APK.

Original comment by sca...@gmail.com on 28 Jul 2012 at 3:13

Attachments:

GoogleCodeExporter commented 9 years ago
please try again :)

Original comment by f...@ub0r.de on 28 Jul 2012 at 3:47

GoogleCodeExporter commented 9 years ago
Hi, 

Looking good so far. Thanks a lot for your efforts scahoo and felix.

Kind regards, 
Ingo

Original comment by ingo.kro...@gmail.com on 29 Jul 2012 at 6:08

GoogleCodeExporter commented 9 years ago

Original comment by sca...@gmail.com on 29 Jul 2012 at 6:17