search

rastapasta / mapscii

🗺 MapSCII is a Braille & ASCII world map renderer for your console - enter => telnet mapscii.me <= on Mac (brew install telnet) and Linux, connect with PuTTY on Windows
MIT License
7.75k stars 251 forks source link

Translate to ESM (ECMAScript Module) #115

Open jaller94 opened 2 years ago

jaller94 commented 2 years ago

More and more of our dependencies transitioned to ESM.

To keep up with security fixes, it seems that we need to transition to ESM as well.

Merging after 1 week, if no one reviews this.

rastapasta commented 2 years ago

Aloha @jaller94 - thanks for all your updates here, I'm a bit hesitant of merging them right away as I see it more as a decorative update of the code generated by your CoffeeScript converter.

Just to keep you in the loop, MapSCII v2 is slowly progressing in the currently limited free time (with some fundamental refactors for usability of MapSCII from inside other cli applications and a full switch, as already desired back then, to TypeScript). I would recommend limiting the time spent on updating/beautifying the current codebase - next to security patches. Cheers!

jaller94 commented 1 year ago

Hi @rastapasta,

all my PRs so far have been hand-translated. I didn't use a converter.

This PR and #117 are pretty good refactors, even if Mapscii 2 is on its way.