Add preliminary support for parsing of command line options

rastapasta / mapscii

🗺 MapSCII is a Braille & ASCII world map renderer for your console - enter => telnet mapscii.me <= on Mac (brew install telnet) and Linux, connect with PuTTY on Windows

MIT License

7.93k stars 256 forks source link

Add preliminary support for parsing of command line options #86

Closed Sword-Smith closed 4 years ago

Sword-Smith commented 4 years ago

This looks like an excellent addition by @lennonhill. Merge?

hrdl-github commented 4 years ago

Type validation is still outstanding, as the argument parser is not strict about those.

rastapasta commented 4 years ago

Aloha and thanks for checkin' in :) I would strongly prefer using yargs's way of defining default values instead of having to merge objects and filtering by unset args. Feels a bit error-prone. Values can still be pulled in from the config, it should just be avoided that the variables are set at different points at code @ maintainability.

hrdl-github commented 4 years ago

Is this better?