search

rastapasta / mapscii

🗺 MapSCII is a Braille & ASCII world map renderer for your console - enter => telnet mapscii.me <= on Mac (brew install telnet) and Linux, connect with PuTTY on Windows
MIT License
7.76k stars 252 forks source link

Unimplemented type: 4 #87

Open harriott opened 4 years ago

harriott commented 4 years ago

Steps to reproduce linux 5.7.4.arch1-1, in either urxvt or xterm:

$ npx mapscii
Welcome to MapSCII! Use your cursors to navigate, a/z to zoom, q to quit.Error: Unimplemented type: 4
    at Pbf.skip (/usr/lib/node_modules/mapscii/node_modules/pbf/index.js:211:20)
    at Pbf.readFields (/usr/lib/node_modules/mapscii/node_modules/pbf/index.js:46:45)
    at new VectorTile (/usr/lib/node_modules/mapscii/node_modules/@mapbox/vector-tile/lib/vectortile.js:8:23)
    at Tile._loadTile (/usr/lib/node_modules/mapscii/src/Tile.js:33:17)
    at /usr/lib/node_modules/mapscii/src/Tile.js:24:19
renderer is busy

and nothing more appears - no map. Exactly the same when I run mapscii installed from AUR.

Quillbert commented 3 years ago

I have been getting this same error on a Raspberry Pi Zero. It occurs when zoom is between 2 and 3, then it works fine, then it stops again at 4.

NeilsC commented 3 years ago

Same issue on Ubuntu 20.04 with mapscii v0.3.1 installed via snap.

jaller94 commented 3 years ago

PBF is a file format for map tiles used by MapSCII. A few tiles at those zoom levels contain data of an optional type 4 (info). https://github.com/rastapasta/mapscii/issues/71#issuecomment-512737220

  1. Long-term this type should get supported or ignored in the upstream dependency pbf.
  2. Generally, it would be good to catch errors while loading tiles and display them somewhere.

The map data is a static snapshot from a few years back. Clearing the cache won't help until the map data is updated.

This affects all platforms and current versions.

dreirund commented 1 year ago

I have this too; what is the state of fixing this?