search

rastasheep / alpine-node-chromium

Dockerized chromium inside node alpine image
MIT License
37 stars 22 forks source link

Node-14-alpine-labels #14

Closed clopez-applaudo closed 3 years ago

clopez-applaudo commented 3 years ago

Good day Aleksandar,

Added the version for Node 14 using the same configuration as usual since I noticed that Angular 12 does not work with the image using node 12. I'm already using this configuration in a project so I can confirm there is no issues with the original configuration you created.

I also replaced the MAINTAINER with LABEL following the documentation https://docs.docker.com/engine/reference/builder/#maintainer-deprecated

Thanks for the images, helps a lot for CI/CD.

rastasheep commented 3 years ago

@clopez-app Awesome work, will merge and update docker hub during the day.

rastasheep commented 3 years ago

Everything published, thanks again for your contribution.

clopez-applaudo commented 3 years ago

Happy to help! Thanks for the update in docker hub.