Rubocop autocorrections on whole codebase

rastating / wordpress-exploit-framework

A Ruby framework designed to aid in the penetration testing of WordPress systems.

https://rastating.github.io/wordpress-exploit-framework

GNU General Public License v3.0

1.02k stars 265 forks source link

Rubocop autocorrections on whole codebase #43

Closed ipepe closed 6 years ago

ipepe commented 6 years ago

I suggest merging this after #42 and #44

ipepe commented 6 years ago

@rastating Why travis is testing on 2.3.4?

rastating commented 6 years ago

I'm going to close this PR for now- there are a number of suggestions made by Rubocop that are a bit OTT, and make the code a bit less readable / maintainable (in my opinion); so an auto correct ends up making some things overly dry. With so many files changed in a single sweep though - it's a bit more difficult to filter them out.

Thanks for the contribution and the previous pull request though (to prepare for Ruby 3.x)