search

rasteiner / k3-awesome-picker

Kirby 4 field plugin to show and select a free Font Awesome icon.
MIT License
15 stars 0 forks source link

Search doesn't work #4

Closed Werbschaft closed 3 years ago

Werbschaft commented 3 years ago

When using the Picker with the Font Awesome Pro Version the search doesn't work, I get the attached error.

Bildschirmfoto 2020-10-19 um 09 35 39
rasteiner commented 3 years ago

could you share a single icon declaration from your icons.yml?

free icons look like this:

accessible-icon:
  changes:
    - 5.0.0
  label: Accessible Icon
  search:
    terms:
      - accessibility
      - handicap
      - person
      - wheelchair
      - wheelchair-alt
  styles:
    - brands
  unicode: f368
  voted: false

do pro version icons look different?

Werbschaft commented 3 years ago

Here are a few examples

500px:
  changes:
    - '4.4'
    - 5.0.0
  label: 500px
  search:
    terms: []
  styles:
    - brands
  unicode: f26e
  voted: false
abacus:
  changes:
    - 5.3.0
  label: Abacus
  search:
    terms:
      - addition
      - ancient
      - arithmetic
      - calculator
      - counting
      - hexadecimal
      - math
      - subtraction
  styles:
    - solid
    - regular
    - light
    - duotone
  unicode: f640
  voted: false
accessible-icon:
  changes:
    - 5.0.0
  label: Accessible Icon
  search:
    terms:
      - accessibility
      - handicap
      - person
      - wheelchair
      - wheelchair-alt
  styles:
    - brands
  unicode: f368
  voted: false
rasteiner commented 3 years ago

that's strange. They seem identical to the free ones. Do the free ones work for you?

Werbschaft commented 3 years ago

Yes, free ones are working. Maybe it's cause I use it on the site and not a page? But should be similar right? Should I provide you with the whole file?

rasteiner commented 3 years ago

site or page shouldn't matter, actually I'm doing my tests on the site, too. Would you email me file?

Werbschaft commented 3 years ago

I have send you a package with all necessary files 😃 It's 6.5 MB, I hope you get it ...

rasteiner commented 3 years ago

Got it :) it was the cctv icon causing problems, it had 1984 as search term and that was interpreted as number (not a string) therefore the "toLowerCase" function didn't exist.

chrfickinger commented 3 years ago

Just want wo mention the great work so far. Good job!

Werbschaft commented 3 years ago

Works 😃