rasteiner / k3-pagesdisplay-section

K3 plugin: display any page list in a section. Any parent, many parents, filtered, don't care.
Other
45 stars 8 forks source link

support for kirby 3.7+ #16

Closed jaro-io closed 2 years ago

jaro-io commented 2 years ago

hey @rasteiner 💡 ✨ i was just playing around with the kirby 3.7.0-rc.1 version and it seems like there are some issues with your plugin after upgrading. if you have a minute, it would be super cool if you could have a look at this. the error i am seeing looks like this:

error

thank you so much for being part of the kirby world. your plugins are so good! 🌻


edit 1: fyi, might be related to https://github.com/getkirby/kirby/pull/4247. edit 2: i guess a dream coming true would be if we could use the new table layout with your plugin as well. 🥰

notes:
  type: pagesdisplay
  layout: table
  columns:
    subheading:
      label: Subtitle
    date:
      label: Date
      type: date
      display: DD.MM.YYYY
    tags:
      label: Tags
      type: tags
rasteiner commented 2 years ago

edit 2: i guess a dream coming true would be if we could use the new table layout with your plugin as well. 🥰

That should work out of the box since my plugin doesn't really come with a front-end part. I'll have a look at 3.7 as soon as I can. Or see if @texnixe does the work first ;) (just kidding)

jaro-io commented 2 years ago

@rasteiner fyi https://github.com/getkirby/kirby/issues/4380

distantnative commented 2 years ago

We fixed the conflicting query computed prop we introduced (for section search) - calling ours now searchterm. Will be in 3.7.0-rc.2.

jaro-io commented 2 years ago

@rasteiner i can confirm that this has been fixed with 3.7.0-rc.2! thank you so much @distantnative.

the only thing i just noticed that’s still not working is the new search: true option. it works fine with a pages section, but not with a pagesdisplay section. would be so great to have it here too! but i dont know if that’s possible.

rasteiner commented 2 years ago

Should work now in version 0.2

jaro-io commented 2 years ago

@rasteiner confirmed! thank you so much! such a poweful feature, especially when combined with your plugin. 💛

timkinali commented 2 years ago

@rasteiner search not working for me with Kirby 3.7.3 and pagesdisplay 0.2.2. Search bar is visible but the list is never filtered when attempting to search. Same for all layout modes. Working with type:pages but not type:pagesdisplay.

jaro-io commented 2 years ago

@rasteiner @timkinali i can confirm this as well.

jonasfeige commented 2 years ago

Same here re:search not working. Any chance for a fix?

rasteiner commented 2 years ago

Oh. Haven't seen this since the issue was closed. Kirby changed this in 3.7.2 here

rasteiner commented 2 years ago

should work again in 0.2.3

jonasfeige commented 2 years ago

should work again in 0.2.3

Amazing, thanks for the quick fix!