Dialog and button enhancements - Githubissues

raster-foundry / blasterjs

React UI library designed and built by Azavea

https://raster-foundry-blaster.netlify.com

Other

6 stars 3 forks source link

Dialog and button enhancements #215

Closed lederer closed 5 years ago

lederer commented 5 years ago

Overview

Button

Theme structure changed so default colors are now configured in colors.

Dialog

Overlay color and opacity can now be themed or propped.
Custom transitions can now be themed.
z-index can now be propped.
Focus ring color can now be themed, and has a default value.

Checklist

[x] Relevant documentation pages have been created or updated
[x] Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
[ ] Relevant status has been updated on the status page

Upgrade instructions

If there are any of the following in this PR, provide proper instructions on how to upgrade:

[x] Changes to the prop names or types of existing components
[ ] Changes in intended behavior of existing component props
[x] Changes in the theme file's structure
[ ] A required version bump to a non-dev dependency of the project

Button theme changes:

intents.colors.default is now base.colors.color
base.colors.defaultBg is now base.colors.bg
base.colors.defaultBorder is now base.colors.border
base.colors.darkText is now base.colors.colorDark
base.colors.lightText is now base.colors.colorLight
base.hover.colors.defaultBg is now base.colors.bgHover
All other base.hover.* properties deprecated, and base.hover removed.

Dialog prop changes:

opacity should now affect dialog opacity, not overlay opacity
Added overlayOpacity
Added overlayColor
Added zIndex
Deprecated: portalClassName, overlayClassName, className, bodyOpenClassName, htmlOpenClassName

Dialog theme changes:

Added colors.overlay
Added colors.focus
Added zIndices.zIndex
Added opacities.overlay
Added durations.closeTimeoutMS
Added transitions.overlay.{base, afterOpen, beforeClose}
Added transitions.dialog.{base, afterOpen, beforeClose}

Notes

Tweaked replaceThemeRefs() in utils.js to help prevent call stack errors.

Hard coded Dialog classnames, for simplicity.

Hid Field, ToggleField, and NavBar docs pages. They're to be deprecated.

Testing Instructions

Fiddle with new Button theme values. Confirm works as expected.
Fiddle with new Dialog props and theme values. Confirm works as expected.

Closes #210 Closes #211 Closes #212 Closes #213

lederer commented 5 years ago

Nice catches. Ready for another look.