Make Select work with Label via `htmlFor` and `id` props - Githubissues

raster-foundry / blasterjs

React UI library designed and built by Azavea

https://raster-foundry-blaster.netlify.com

Other

6 stars 3 forks source link

Make Select work with Label via `htmlFor` and `id` props #228

Closed lederer closed 5 years ago

lederer commented 5 years ago

Overview

Ensure <Select> passes id prop down to nested <select> element.

Document use of htmlFor prop with <Label>.

Checklist

[x] Relevant documentation pages have been created or updated
[ ] Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
[ ] Relevant status has been updated on the status page

Upgrade instructions

If there are any of the following in this PR, provide proper instructions on how to upgrade:

[ ] Changes to the prop names or types of existing components
[ ] Changes in intended behavior of existing component props
[ ] Changes in the theme file's structure
[ ] A required version bump to a non-dev dependency of the project

Testing Instructions

Examine second example on <Label> docs page. Ensure clicking the label focuses on the associated <select> element.

Closes #225. Closes #226.