search

rasterio / affine

Affine transformation matrices
BSD 3-Clause "New" or "Revised" License
156 stars 28 forks source link

switch to github actions #73

Closed vincentsarago closed 2 years ago

vincentsarago commented 2 years ago

closes #70

vincentsarago commented 2 years ago

coveralls step fails but I don't really know why 🤷

sgillies commented 2 years ago

Thanks for starting this @vincentsarago ! Do we need to install the coveralls app or something?

vincentsarago commented 2 years ago

Do we need to install the coveralls app or something?

I don't think, coveralls is installed when we do pip install .["test"] and because we are using coveralls action we should be good to go

mwtoews commented 2 years ago

Re: dropping Python 2, I thought about this a while ago, but it wouldn't significantly change the codebase. I suggest keep the support, but I'm indifferent whether it should be tested in CI.

sgillies commented 2 years ago

@vincentsarago I often look to attrs as an example. In https://github.com/python-attrs/attrs/blob/main/.github/workflows/main.yml#L51 it looks like coverage is a different job from the tests. See https://github.com/python-attrs/attrs/runs/5735691095?check_suite_focus=true. What do you think about that approach?

vincentsarago commented 2 years ago

🤔I still get No files were found with the provided path: .coverage.*. No artifacts will be uploaded. which seems to tell that no .coverage files were created. Locally it creates files 🤷‍♂️

I don't really understand why coveralls complain about missing files. Looking at the log, it seems that some .coverage.* files are updated to the artefact storage and then downloaded during the lint_and_cov job 🤷‍♂️

vincentsarago commented 2 years ago

Alright I was getting bored of coveralls not working. I switched to codecov... I will agree if you won't want to use it but then I'll defer to someone with better coveralls skills to finish this PR 😄

sgillies commented 2 years ago

@vincentsarago I honestly don't have a preference. I might look into this approach in the future: https://github.com/python-attrs/attrs/blob/980c8b04f59d93c429fc66d901d2a24c70a8d777/.github/workflows/main.yml#L51. I'm a big fan of Hynek's work.