fix: fail early if there is no tmp dir specified

raszi / node-tmp

Temporary file and directory creator for node.js

MIT License

736 stars 92 forks source link

Closed silkentrance closed 5 years ago

silkentrance commented 5 years ago

Fixes #176.

This will cause _generateTmpName to fail early if both opts.dir and tmpDir are undefined.

silkentrance commented 5 years ago

Still working on tests for this...

silkentrance commented 5 years ago

@raszi thank you for the review. I will try to address these issues ASAP.

silkentrance commented 5 years ago

Please also add tests.

Missing tests have been added.

silkentrance commented 5 years ago

@raszi tests have been added.

silkentrance commented 5 years ago

Merging now as all change requests have been met.