search

raszi / node-tmp

Temporary file and directory creator for node.js
MIT License
736 stars 92 forks source link

dir option must always be relative to the standard tmp directory #207

Closed silkentrance closed 4 years ago

silkentrance commented 4 years ago

The dir option must be relative to the existing tmp directory that is provided by the process environment.

tmp will expect that the so defined directory is in place, otherwise it will fail as it will not create the directory by itself.

The current solution may pose issues and potential risk, see #205

The tmp directory should always and only be configured in the process environment and not by the application itself.

This might have a potential impact on existing applications and the change must be communicated well.

silkentrance commented 4 years ago

see also #219

silkentrance commented 4 years ago

having a dir option that is always relative to the os/environment provided temporary directory requires tmp to recursively create that directory, if it does not exist in order to relieve the user from doing so in every one of his applications.

we could use https://github.com/substack/node-mkdirp for that.