raszi / node-tmp

Temporary file and directory creator for node.js
MIT License
736 stars 92 forks source link

Release v0.2.0 #233

Closed silkentrance closed 4 years ago

silkentrance commented 4 years ago

In order to overcome the most pressing issues: #216, #213, #207, #218, #236, #237, #238, #176, #156.

I make the following proposal in order to further stabilize tmp and to get a new release out of the door as soon as possible.

@raszi please have a look and tell me if that would suit you. Exposing the garbage collector as a callable has its own issues, see the comments in #216.

silkentrance commented 4 years ago

See PR #234

alubbe commented 4 years ago

@raszi any news on this? We'd love to upgrade to 0.2.0 for exceljs

nomcopter commented 4 years ago

When will this release? I don't even use node-tmp but this is breaking SIGINT handlers in an application of mine because a random dependency uses this which forces a complete process exit on SIGINT.

silkentrance commented 4 years ago

@raszi What about a new release on npmjs.com?

ezze commented 4 years ago

Still waiting for it for months. Some time ago SIGINT issue have been fixed in master and then broken again. For those who is experiencing the same issue here is a temporary workaround to stick to exact working old commit:

$ rm -Rf node_modules
$ yarn remove tmp
$ yarn cache clean
$ yarn add raszi/node-tmp#ae61bb63dbc05ff66678b992a14a19f44ab899ed
silkentrance commented 4 years ago

@ezze @nomcopter @raszi just released version 0.2.0 to npmjs. Have fun.

alubbe commented 4 years ago

Thanks a bunch!

ezze commented 4 years ago

@silkentrance Thanks for doing it. Unfortunately, new release solving SIGINT issue introduces other breaking changes such as this one: https://github.com/raszi/node-tmp/issues/250

At the moment, we can't live with it, so I created forked npm package tmp-sigint that implements my workaround mentioned above for 0.1.0 (I decided to create it due to yarn 1.22.4 doesn't work well with commits breaking yarn.lock on each dependencies installation).

missinglink commented 3 years ago

Hi @silkentrance, @raszi, the semantic versioning spec adopted by most npm modules requires that breaking changes increment the major version number.

In this release you've published 0.2.0 when it should really be 1.0.0, this helps downstream consumers better control which updates they accept automatically and which require manual review.

https://semver.org/