raszi / node-tmp

Temporary file and directory creator for node.js
MIT License
736 stars 92 forks source link

feat: stabilize tmp for v0.2.0 release #234

Closed silkentrance closed 4 years ago

silkentrance commented 4 years ago

TODO

silkentrance commented 4 years ago

Future TODO

silkentrance commented 4 years ago

darn windows build is now failing with a EBADF, investigating

silkentrance commented 4 years ago

fixed, needed YAWSWA (yet another windows specific work around)

function _isExpectedError(error, errno, code) {
  return IS_WIN32 ? error.code === code : error.code === code && error.errno === errno;
}
silkentrance commented 4 years ago

ATM I do not have time for this, started on a new job and have to get up to speed there first.

silkentrance commented 4 years ago

The travis-ci builds are no longer showing:

https://travis-ci.org/github/raszi/node-tmp/builds/672652698

silkentrance commented 4 years ago

@raszi I think I am done with this PR. I fixed all the issues listed. You might want to have another look and if everything is ok, we can finally merge this and you can make a new 0.2.0 release :rocket:

raszi commented 4 years ago

Nice work @silkentrance