raszi / node-tmp

Temporary file and directory creator for node.js
MIT License
736 stars 92 forks source link

We need to have a more thorough code peer review #243

Closed silkentrance closed 2 years ago

silkentrance commented 4 years ago

In the past, I did rework most of the tests and also contributed to the core code base. However, some vital mistakes that had been introduced by me have not been found out during PR reviews, and this does not include linting problems only.

So if you do a review, at least do it thoroughly, as I am not capable of finding my own mistakes unless they are exposed by existing and working tests. And sometimes I fail to implement these tests.