search

raszi / node-tmp

Temporary file and directory creator for node.js
MIT License
736 stars 92 forks source link

Why SIGINT rather than beforeExit? #247

Closed arcanis closed 4 years ago

arcanis commented 4 years ago

I'm using tmp in Yarn, but it causes problems where other SIGINT handlers aren't registered due to tmp overriding them with its own (I'm not entirely sure about the order of execution to be honest, but it's clear tmp has a role into this).

Why is node-tmp catching SIGINT in the first place rather than using the beforeExit handler?

lpgera commented 4 years ago

Yeah, this issue caused a massive headache for me too. Our production web app relies on a SIGINT handler to shut down (or reload) gracefully, which it started to not do after we've included this package.

CleyFaye commented 4 years ago

edit: I just saw #233 . Guess it's soon going to not be an issue anymore.

raszi commented 4 years ago

Closed by #233