Closed JamesJieranShen closed 3 months ago
We can announce this on the next call and merge then.
per comment by @gmwendel I've changed the name of the old branch to mcPEHitTime
, in accordance to the naming of the variable internal to RAT::DS::Photon. I personally have no strong opinion to this either way. If others do, I am happy to revert this change.
@tannerbk Can we merge this?
Potentially breaking!
Old
mcPETime
in ntuple is the time that front-end electronics see a detected photon, which includes timing effects of the PMT. This PR modifies this behavior such that the branchmcPETime
now records the time that a photon hits the PMT. The front-end time is written to a new branch namedmcPEFrontEndTime
.Since this change assigns an old variable name to a new definition, previously-implemented analysis may need to be modified to account for it.