search

rat-pac / ratpac-two

Open source edition of RAT-PAC
Other
11 stars 23 forks source link

Annri gd g411 #137

Closed opercjy closed 3 months ago

opercjy commented 3 months ago

particle discrete process

JamesJieranShen commented 3 months ago

Hello, thanks for submitting this PR! In RAT-PAC2, we have shifted a model where rat should be built as a library to a downstream experiment repo. This means that there should not be experiment-specific code in rat itself. Please take a look at https://github.com/rat-pac/RatpacExperiment to see how to build an example experiment.

Changes to rat-pac2 should only be related to shared resources -- for example, additional PMT models, additions/improvements to the physics model.

Given that the bulk of this PR is experiment-specific code, I am closing it for now. Feel free to submit another PR if you would like to implement changes that align with what I just described. Feel free to contact us as well should there be any further questions.

jhgoh commented 2 months ago

Thank you for checks and closing the PR. This PR supposed to be sent in a different repo/branch but @opercjy clicked wrong button :-) And thank you for providing useful information how to deal with the experiment-specific codes.