search

rat-pac / ratpac-two

Open source edition of RAT-PAC
Other
11 stars 23 forks source link

Add channel number to the DS for the PMT objects #150

Closed tannerbk closed 1 month ago

tannerbk commented 1 month ago

This allows one to grab the channel number directly rather than relying on using the meta data to create a map from PMT ID to channel number.

JamesJieranShen commented 1 month ago

I'm not sure if it is necessary to add all the pmt_channel fields in MCPMT/PMT objects. The information is available in RUN::PMTInfo. I do agree though that we should write this to the ntuple. This can be done with a PMTInfo lookup.

JamesJieranShen commented 1 month ago

Merge conflict means this may need to be rebased?

tannerbk commented 1 month ago

Yeah I'm going to close this for now and simplify according to your suggestions.