search

ratal / mdfreader

Read Measurement Data Format (MDF) versions 3.x and 4.x file formats in python
Other
169 stars 74 forks source link

":" not in signal name #119

Closed rolfub closed 6 years ago

rolfub commented 6 years ago

Hello Aymeric,

is it possible that you filter ":" out of signal names? I miss them in masterChannelList().

Yours sincerely,

Rolf

ratal commented 6 years ago

Hi Rolf, Possible for version before 2.7.2 Which one are you using ? And mdf version ? There was annoying issues with channel names and python attributes names limitation for recarrays (issue #109 ) If you export, there are limitations for the variable naming, especially with Matlab. Aymeric

rolfub commented 6 years ago

Hello Aymeric,

we use version 2.7.2. The file has mdf version 4.1. Numpy version is 1.11.1.

Rolf

danielhrisca commented 6 years ago

Hello Rolf,

as seen in #109 if you use numpy 1.13.1 you should not get this error anymore.

rolfub commented 6 years ago

Thank you Daniel, we will test it. Rolf

danielhrisca commented 6 years ago

Hello Rolf, we should all thank the numpy guys :)

ratal commented 6 years ago

Hi Rolf, I just found a self['name'] = self['name'].replace(':', '') at the end of CNBlock.read in mdfinfo4, could be your issue. No reason to have this code anymore, I will remove it for next commit.

ratal commented 6 years ago

About a month no feedback => issue should be fixed. Do not hesitate to repoen.