ratal / mdfreader

Read Measurement Data Format (MDF) versions 3.x and 4.x file formats in python
Other
169 stars 74 forks source link

numpy import error in 3.0.0 if no cython #158

Closed DocBO closed 5 years ago

DocBO commented 5 years ago

Python version

3.7.1

Platform information

Linux-4.15.0-42-generic-x86_64-with-debian-buster-sid

Numpy version

1.15.4

mdfreader version

3.0.0

Description

The setup.py is not working correctly if cython is not installed. You get an numpy error (which is not defined in that case since it is never imported).

If cython is installed by hand previously, everything works fine. So either include cython into your depencies or import numpy on another place too.

ratal commented 5 years ago

Hi, there was a remaining include_dirs=[numpy.get_include()] in case extension could not be compiled, removed and this error should not happen. If you have occasion can you confirm ?

ratal commented 5 years ago

Seems it is fixed, thanks for reporting, closing issue.