search

ratal / mdfreader

Read Measurement Data Format (MDF) versions 3.x and 4.x file formats in python
Other
169 stars 74 forks source link

bug: wrong output in mdf version3 #73

Closed danielhrisca closed 7 years ago

danielhrisca commented 7 years ago

Using the test.mdf file, for the channel _FAIL_RAM_MEM21 the output from mdfreader 0.2.5 is fail_ram_mem_21_nok and it should be fail_ram_mem_21_ok

(Python 3.4.4 32 bit, mdfreader 0.2.5, numpy 1.11.3)

ratal commented 7 years ago

Definitely, I do not understand what is your environment difference with mine that could cause this error. I could not reproduce your issue, I have what you expected. exact try from my side: python 3.5.3 64bit, python 2.7.13 64bit, numpy 1.11.2, debian I will try on windows environment with anaconda

danielhrisca commented 7 years ago

I only use WinPython distributions on Windows (7 x64 and 10 x64).

ratal commented 7 years ago

I tried with anaconda on win10 and python 3.6.0 64bit, anaconda 4.3.1, numpy 1.11.3 and I could not reproduce your issue.

danielhrisca commented 7 years ago

WinPython uses numpy compiled with Intel MKL library. Maybe this could be the root cause. I'll check to see if regular numpy works correctly.

danielhrisca commented 7 years ago

I've tried this on Ubuntu, and I still get an error:

image

ratal commented 7 years ago

I am a bit puzzled. Are you testing the same file that you sent me ?

danielhrisca commented 7 years ago

It's the same file attached to issue #67

ratal commented 7 years ago

ok, I'll test with winPython on Windows

ratal commented 7 years ago

I tried on win10 with winPython 3.5.3 zero and installed from pythonlibs numpy with mkl and I could not reproduce your issue. I also tried with winPython 3.6.1 complete, I could not also reproduce your issue. Sorry I am a bit stuck there. Are you sure you did not do any modification to the code ?

danielhrisca commented 7 years ago

Well I've installed WinPython on two different machines and I get this issue. One a third machine with Ubuntu I've pip installed mdfreader and again I get the issue. To make sure I'm using the 170 MB with 36424 channels.

ratal commented 7 years ago

I am using virtualbox for win10 on the same machine but I doubt this could be the reason I cannot reproduce, considering you have also this problem with ubuntu. I also tried on another machine with ubuntu, still I cannot reproduce. I think we are trying with the same file, same number of channels (a lot) but just in case, the one you sent me has 192.5Mo ? Also I do not use pip but rather python setup.py develop in the source folder.

danielhrisca commented 7 years ago

Then it is not the same file. It should be a mdf version 3 file of 176,1MB. If you extract again the attachment from issue #67 you will have the correct file.

ratal commented 7 years ago

ok, good news, I can reproduce and will investigate

ratal commented 7 years ago

Hi, Last commit should have solved this issue and #74 Can you check it ?

danielhrisca commented 7 years ago

Hi, I will try this next week

danielhrisca commented 7 years ago

Hello Aymeric,

the latest master solves this issue.