search

ratal / mdfreader

Read Measurement Data Format (MDF) versions 3.x and 4.x file formats in python
Other
169 stars 74 forks source link

Bug fixes and improvements #76

Closed skelliam closed 7 years ago

skelliam commented 7 years ago
  1. Fix some typos in readme
  2. Bugfix in mdf3 writer: byteoffset field was hardcoded to zero. Thus if bitoffset exceeds 0xFFFF (which it will if you have a lot of signals) the program would crash.
  3. Add "rename_channel" method.
  4. Add try/except in a couple of places that were giving me troubles
ratal commented 7 years ago

Hi Skelliam, Thanks again for your pull request. I implemented most of it by hand because of some indents messing and conflicts (I feel not so easy to choose or adapt part of code to be merged in github) So I added as you proposed typ fix for README, byteoffset handling and added rename_channel method. However, I could not find the reason for some try: with my test files. I would rather prefer to find out why record is not found for instance than putting a try --> you can give a try of last commit and raise issue instead ?