ratal / mdfreader

Read Measurement Data Format (MDF) versions 3.x and 4.x file formats in python
Other
169 stars 74 forks source link

Mixed up signals values in 0.2.6 #94

Closed SubspaceBob closed 6 years ago

SubspaceBob commented 6 years ago

I have an issue with 0.2.6 not found in 0.2.5 where one signal gets the same values as another signal with very similar name. Using 0.2.5 I get the correct values. capture error.zip

Using python2.7 32bit on Windows. Thanks for an awesome tool!

meisterlumpi commented 6 years ago

Actually, I had this exact issue with 0.2.5. With 0.2.6 it seems to be fixed. Didn't do extensive testing yet, though..

danielhrisca commented 6 years ago

in 0.2.5 there was a problem with overlapping channels

see issue #80

SubspaceBob commented 6 years ago

Anyone can feel free to try the read the dat-file, included in the error.zip together with a small script for creating two plots. The two plots should not be equal...

danielhrisca commented 6 years ago

Indeed seems to be a new issue in 0.2.6

xVcScADrvrDesDir_B_Lvr2TipUp

image

vs corect

image

xVcScADrvrDesDir_B_Lvr2TipDown

image

vs correct

image

ratal commented 6 years ago

Hi, there was an error calculating channel.embedding_channel_bitOffset Indeed this part of the code computing bit channels was completly reviewed for 0.2.6 Last commit should fix it, can you try ?

ratal commented 6 years ago

Is it solved for everybody ?

SubspaceBob commented 6 years ago

I have not the ability to test the change until it is included into a new wheel on pypi. Thanks for your effort!!

2017-11-02 23:33 GMT+01:00 Aymeric Rateau notifications@github.com:

Is it solved for everybody ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ratal/mdfreader/issues/94#issuecomment-341577931, or mute the thread https://github.com/notifications/unsubscribe-auth/AblBdNfTGGMADpj-lRHP-ONw2wvW-q3uks5sykM5gaJpZM4P2Dvx .

ratal commented 6 years ago

I pushed new release in pypi, you can have a try

SubspaceBob commented 6 years ago

This issue is fixed in 0.2.7, but the signals don't have the correct name when printing the keys(), the names are signalname_0 or signalname_1. They are appended by a _0 or _1. Why is that? So i'm sticking with 0.2.5 for a while longer. Should i confirm this as solved an create a new issue??

I also tried 2.7.1 but got: ImportError: cannot import name getlogin What is this? Running 2.7.14

cristi-neagu commented 6 years ago

The channel name issue has been flagged and solved in #105.

danielhrisca commented 6 years ago

mdfreader version went from 0.2.7 to 2.7.1

ratal commented 6 years ago

You could try last commit, I fixed it I think. getlogin is only available for unix platform, I introduced this condition for import and usage.