ratalaika / angel-engine

Automatically exported from code.google.com/p/angel-engine
0 stars 0 forks source link

World::CleanupRenderables does not actually cleanup renderables #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi all; I noticed when working with the engine (I'm starting to love angel
btw ;)) that World::CleanupRenderables does not actually free memory.  The
delete command was commented out for some reason?  So here's a super simple
fix for it which now deletes memory.

Hope this helps!

Original issue reported on code.google.com by Sim9OLDA...@gmail.com on 10 Apr 2009 at 3:20

Attachments:

GoogleCodeExporter commented 9 years ago
I believe that having the deletion in there caused some kind of problem, but I 
can't
remember what at the moment. I agree that the Destroy() function (and subsequent
CleanupRenderables()) *should* free the memory, but that was commented out 
because
leaking memory is preferable to crashing. :-) 

Thanks for the reminder -- I'll look into this more thoroughly. Let us know if 
you
run into any other issues with Angel! 

Original comment by lieseg...@gmail.com on 16 Apr 2009 at 3:13

GoogleCodeExporter commented 9 years ago
Fixed in the reorg branch. 

Original comment by lieseg...@gmail.com on 3 Jul 2010 at 1:08