ratanakvlun / deluge-ltconfig

292 stars 35 forks source link

Load preset does nothing #14

Closed ormanya closed 5 years ago

ormanya commented 7 years ago

When I choose a new preset and click Load Preset nothing happens, clicking Apply in settings window, then coming back to ltconfig settings and still no changes. Both the setting and actual columns are unchanged.

Using: Deluge GTK client: OS X 1.3.15 Deluged: Linux 1.3.15 lib torrent: 1.0.11.0 ltconfig: 0.3.1

ratanakvlun commented 7 years ago

Are you able to change individual settings?

ormanya commented 7 years ago

Yes, I can change individual settings

ratanakvlun commented 7 years ago

When you click Load Preset, it doesn't show the changes in the setting column?

ormanya commented 7 years ago

ltconfig.mov.zip

Correct. The setting column does not change and none of the settings change from grey to black font. If I make the change, exit Preferences, then go back in, the preset dropdown still shows my new selection (but no changes in actual settings). However, if I disconnect the thin client then reconnect it, the dropdown is reset to Pre-ltConfig Settings. It seems that the change is only being made in the thin client and not registering with the server. I attached a movie showing the behaviour.

ratanakvlun commented 7 years ago

I am unable to access the movie file. Can you check the url?

ormanya commented 7 years ago

Hmmm, strange. I just uploaded it via the github file attachment tool. Try this instead: http://www.sekrit.me/ltconfig.mov

ratanakvlun commented 7 years ago

Managed to get access to macOS 10.12 and tested this with the official Deluge 1.3.15/libtorrent 1.0.9 dmg. It seems to be working for me.

Make sure both your server and client are using the same ltConfig version. You will have to restart both the server and client.

If it still does not work, try running with logging enabled and look for error messages when you click Load Preset.

ormanya commented 7 years ago

Both are using ltconfig 0.3.1. I also tried restarting the server and client. I checked deluged.log on the server and there were no errors associated with ltconfig. I can't see any way to enable logging on the client end in deluge.app.

Two things that may be helpful:

  1. I am running lib torrent 1.0.11; you tested with 1.0.9
  2. While the client is running on macOS, the server is running on Debian 8
ormanya commented 7 years ago

So removed and reinstalled ltconfig. Still no effect of load preset. I then checked the Apply Settings on startup box, and I could see that this took effect on the server (see log below). Therefore, the client is communicating with the server and is able to save settings on the server. It seems the problem is really limited to loading the preset in the client.

Note that I am using the the deluge.app client (GTK). Is that what you used for testing?

Log of preference changes I described above: https://ghostbin.com/paste/zaqoj

ormanya commented 7 years ago

One more thing as a test. I disabled ltconfig in the macOS client, connected via the web client, installed ltconfig again. In the web client I can see the settings page and make manual changes, but the dropdown menu of presets is greyed out and inaccessible: https://puu.sh/wxtSU/2d1344e221.png

ratanakvlun commented 7 years ago

Yes, I am testing with the gtk client. Where did you get the libtorrent 1.0.11 binary?

The only code in the webui that disables the presets is if the version is less than 0.16, so that is weird.

ormanya commented 7 years ago

It is on his github page: https://github.com/arvidn/libtorrent/releases

However, I am running this on a seedbox, so I did not install the server side myself.

ratanakvlun commented 7 years ago

Also, you can enable logging for the client by running the gtk client binary (should be in the deluge.app directory somewhere) from terminal and using the -l and -L flags (use --help for better explanation of these). Log level should be debug.

ratanakvlun commented 7 years ago

When you click Load Preset, the daemon log (log level debug) should show:

[ltConfig] Get preset 2

On client log (log level debug), you should see something like:

[ltConfig] Loading preset...
[ltConfig] Option=2

Where 2 is a number corresponding to the preset index.

ormanya commented 7 years ago

I have enabled logging on both. When I make changes to individual ltconfig settings or to load settings on startup, I can see the changes logged on the server (and the ltconfig.conf file is updated). However, when I try to load a preset I see nothing in the logs.

ormanya commented 7 years ago

In the client log, I see the ltconfig egg file loaded, but then there is no subsequent mention of ltconfig.

ratanakvlun commented 7 years ago

And no errors?

ormanya commented 7 years ago

No errors. Absolutely nothing gets written to the log when I press the Load Preset button

ratanakvlun commented 7 years ago

And log level is set to debug? What version of macOS are you on? This sounds like the button is not linked to the button logic correctly.

ormanya commented 7 years ago

I started logging on the client system with "/Users/me/Applications/Deluge.app/Contents/MacOS/deluged -L debug -l ~/.config/deluge/deluged.log"

I am running MacOS 10.12.5.

ratanakvlun commented 7 years ago

If you are on the client system, you should run deluge or Deluge. deluged is for the daemon.

ratanakvlun commented 7 years ago

I set up a Deluge 1.3.15, libtorrent 1.0.11 daemon on Debian 8 and used the official Deluge 1.3.15 dmg on macOS 10.12 as the thin client. I can't seem to reproduce the problem.

ormanya commented 7 years ago

Alright. I guess we are stuck! Only reasonable explanation at this point is that it someone on my seedbox companies end, although I am not sure how that would work since I am not seeing a log entry AND I can make manual changes to individual settings. As a workaround, is there anywhere I can find the list of configurations associated with each preset so that I can manually apply them?

ratanakvlun commented 7 years ago

You can find the presets here.

Some settings may not exist in the current libtorrent version and can be ignored.