ratatui-org / ratatui-website

Ratatui Documentation
http://ratatui.rs/
MIT License
95 stars 57 forks source link

Feedback on tui with terminal and event handler recipe #648

Open joshka opened 1 week ago

joshka commented 1 week ago

In a discord conversation about https://ratatui.rs/recipes/apps/terminal-and-event-handler/ I wrote:

It's one way to do things. There's a bunch of things I'd choose to do differently though. (I've never reviewed this before, so this is a first encounter review):

If you don't specifically need async, then I'd avoid this and keep it simple / work out the bits you actually need based on building them up yourself. You might find agreement with some of these points, or disagree with them. That's fine - there's many ways to structure things and many of them will work well. Most of the above tends to the subjective side of things rather than purely objective. The code will work for you, but may not be right for you.

I'd suggest leaving this as-is for now, but noting it should be cleaned up a bit in the future once https://github.com/ratatui-org/ratatui/pull/1180 lands