Closed EdJoPaTo closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.3%. Comparing base (
fadc73d
) to head (11d0238
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As an alternative, what about adding a Buffer::reset_range() method - something like:
buffer.reset_range(Position(x, y)..Position(x1, y1));
Probably unnecessary over-engineering (this PR is approved without that change)
Guess that would be neat for #1122. And probably out of scope for this PR.
Using reset is clearer to me what actually happens. On the other case a struct is created to override the old one completely which basically does the same in a less clear way.