ratatui-org / ratatui

Rust library that's all about cooking up terminal user interfaces (TUIs) 👨‍🍳🐀
https://ratatui.rs
MIT License
8.86k stars 269 forks source link

fix(color): change parse error message to single color #1139

Closed EdJoPaTo closed 1 month ago

EdJoPaTo commented 1 month ago

Found while enabling https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_result_states

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.2%. Comparing base (cf67ed9) to head (10f52c3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1139 +/- ## ===================================== Coverage 94.2% 94.2% ===================================== Files 60 60 Lines 14630 14632 +2 ===================================== + Hits 13790 13792 +2 Misses 840 840 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EdJoPaTo commented 1 month ago

These messages should be lowercase.

Thought about that too, but it's about the struct Color.

joshka commented 1 month ago

These messages should be lowercase.

Thought about that too, but it's about the struct Color.

Failed -> failed

EdJoPaTo commented 1 month ago

My main intention was to enable this lint and fix the mistake of outputting colors instead of color. As this seems to be more complicated about stuff I don't use in the first place (= don't care much about it) I'll just close this.