ratatui-org / ratatui

Rust library that's all about cooking up terminal user interfaces (TUIs) 👨‍🍳🐀
https://ratatui.rs
MIT License
8.82k stars 263 forks source link

feat(layout): impl Display for Position and Size #1162

Closed joshka closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.2%. Comparing base (d7ed6c8) to head (b1b4b1c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1162 +/- ## ===================================== Coverage 94.2% 94.2% ===================================== Files 60 60 Lines 14509 14522 +13 ===================================== + Hits 13670 13683 +13 Misses 839 839 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshka commented 1 month ago

I would use 13x37 for a Position too but its probably not that relevant.

As a downside… changing the Display implementation later on is probably a breaking change.

Bikeshed comment, but hard disagree. (x, y) is pretty standard for things which are coordinates.