search

ratatui-org / ratatui

Rust library that's all about cooking up terminal user interfaces (TUIs) 👨‍🍳🐀
https://ratatui.rs
MIT License
8.82k stars 263 forks source link

fix: avoid unicode-width breaking change in tests #1171

Closed joshka closed 3 weeks ago

joshka commented 4 weeks ago

unicode-width 0.1.13 changed the width of \u{1} from 0 to 1. Our tests assumed that \u{1} had a width of 0, so this change replaces the \u{1} character with \u{200B} (zero width space) in the tests.

Upstream issue (closed as won't fix): https://github.com/unicode-rs/unicode-width/issues/55

orhun commented 4 weeks ago

this is kinda annoying lol

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.2%. Comparing base (7f3efb0) to head (fc759f4). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1171 +/- ## ===================================== Coverage 94.2% 94.2% ===================================== Files 60 60 Lines 14522 14523 +1 ===================================== + Hits 13683 13684 +1 Misses 839 839 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.